Instant Launch badges (WIP) #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcorvidae
commented
Oct 9, 2024
psarando
reviewed
Oct 10, 2024
|
It's still a little rudimentary but it's not linked from anywhere yet and basically works so I think I'll merge this PR for now, and open more as I get more things done. Any further reviews/thoughts always welcome. |
psarando
approved these changes
Oct 10, 2024
Comment on lines
+70
to
+80
| <> | ||
| <ErrorTypography | ||
| errorMessage={error.message} | ||
| onDetailsClick={() => setErrorDialogOpen(true)} | ||
| /> | ||
| <DEErrorDialog | ||
| open={errorDialogOpen} | ||
| errorObject={error} | ||
| handleClose={() => setErrorDialogOpen(false)} | ||
| /> | ||
| </> |
There was a problem hiding this comment.
This looks basic enough that this could be replaced with an ErrorTypographyWithDialog.
See components/apps/savedLaunch/SavedLaunchListing for an example (I guess AppInfo wasn't the best example for ErrorTypography, which seems like it could also use an ErrorTypographyWithDialog instead).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (so far) adds a single new page at
/instantlaunches/:id, which immediately launches the provided instant launch.Continuing work: